Skip to content

Conversation

ryanking13
Copy link
Member

This PR exposes three new variables in pyodide config CLI. I think they are useful in package builds.

  • pyodide_root: We can use it when we need to access some of the files in the xbuildenv.
  • pyodide_abi_version: As it is going to be used in PEP 783, I think it is good to expose it in cli.
  • python_include_dir: It can be used in some packages that do not follow PEP517 (e.g. RobotRaconteur)

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ryanking13! Sorry, I didn't notice that you were working on this, so #187 is also changing the same files. I think we should proceed with this PR first, as I have some more merge conflicts to resolve anyway.

As this PR adds python_include_dir, it reminded me of my older PR #14. Do you think I should revive that PR after this is merged? At that stage, I wasn't acquainted with our codebase and the general Pyodide ecosystem, but I think I am now. :)

@ryanking13
Copy link
Member Author

Thanks, @ryanking13! Sorry, I didn't notice that you were working on this, so #187 is also changing the same files. I think we should proceed with this PR first, as I have some more merge conflicts to resolve anyway.

Yes, sorry to introduce a code conflict. I'll go ahead and merge this PR, so you can rebase yours.

As this PR adds python_include_dir, it reminded me of my older PR #14. Do you think I should revive that PR after this is merged? At that stage, I wasn't acquainted with our codebase and the general Pyodide ecosystem, but I think I am now. :)

Sure, please do. I left some reviews in that PR a while ago.

@ryanking13 ryanking13 merged commit 43efecf into pyodide:main Apr 12, 2025
6 checks passed
@ryanking13 ryanking13 deleted the expose-more-configs branch April 12, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants