Skip to content

Conversation

@ryanking13
Copy link
Member

Follow up of #246

@ryanking13
Copy link
Member Author

It seems like there are some libraries that overwrites the CMAKE_C_FLAGS_INIT when CMAKE_C_FLAGS are passed. I am not sure what the best convention is for this, but at least this breaks some existing recipes in pyodide-recipes.

@Andrej730
Copy link

Any particular packages that break with this? Wanted to try to look into it.

@ryanking13
Copy link
Member Author

@Andrej730 I found that it breaks some libraries that we pass custom CMAKE_C_FLAGS (e.g. libzfp). If we change to _INIT variable, setting custom CMAKE_C_FLAGS will overwrite our default flags. Even when users pass custom CMAKE_C_FLAGS we want our default cmake flags prepended as they need to be always present.

I am not sure what is the best way to achieve this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants