Use python.bat for Pyodide python interpreter in Windows #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
agriyakhetarpal
left a comment
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @ryanking13! Should this be python.exe instead of .bat? Windows venvs have a python.exe and a windowless pythonw.exe. I just wanted to verify this before we merge.
Also, could we add a test job in the matrix for this? We can skip all tests on Windows for now via the pytest_collection_modifyitems hook, and run only this test by explicitly marking it to run on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not properly work yet, but we didn't support Windows anyways. This is a preparation for pyodide-build side to make
pyodide venvwork. Rest of the work needs to be done (hopefully), in Pyodide.