Make resolvelib and unearth optional optional dependencies #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
added
the
integration
Member
Author
|
cc: @joemarshall |
agriyakhetarpal
approved these changes
Jan 23, 2026
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -e ".[test]" | ||
| pip install -e ".[test,resolve]" |
Member
There was a problem hiding this comment.
Not for this PR, but how do you feel about switching to dependency groups instead of optional dependencies (for the test dependencies only, not resolve)?
Comment on lines
+62
to
+63
| print(str(e), file=sys.stderr) | ||
| sys.exit(1) |
Member
There was a problem hiding this comment.
I am aware that we use this pattern in quite a few places where we don't use a logger, but how do you feel about changing it to this:
Suggested change
| print(str(e), file=sys.stderr) | |
| sys.exit(1) | |
| sys.exit(str(e)) |
sys.exit() with a string exits with exit code 1 by default.
(and same in the other places in this PR)
| @@ -28,8 +28,6 @@ dependencies = [ | |||
| "rich", | |||
| "platformdirs", | |||
| # TODO: make this a extra dependency | |||
Member
There was a problem hiding this comment.
Suggested change
| # TODO: make this a extra dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our build dependencies to only install
resolvelibandenearchwhen[resolve]extra is given such asThose packages are used for dependency resolution when building packages, which is not a very common usecase. I would like to slowly deprecate that feature after we are able to publish emscripten packages to PyPI.