-
Notifications
You must be signed in to change notification settings - Fork 7
Support Pyodide 0.28 and bump to Python >=3.13 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 33 commits
f15d0e9
db199bb
3940244
3ce8480
ccac8f9
eacee75
7c83198
72a091f
dc0cfc2
9fe3724
4b88204
8b6c1ce
6e35b9f
9b29a0e
b0e99f3
5551c85
6481503
e16d2fe
490c3f1
8462777
4ec4bdf
af67dcc
1cd3e48
886a1bb
02f65fb
af067e7
87b5478
5441b38
58f7016
8795efc
ed4bde3
4b57e0f
3cc8c03
f70fa86
7c6c3e2
31a3f52
16b6787
1d44dce
f7911c5
cf78f2f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,6 @@ python: | |
| path: . | ||
|
|
||
| build: | ||
| os: ubuntu-20.04 | ||
| os: ubuntu-22.04 | ||
| tools: | ||
| python: "3.11" | ||
| python: "3.12" | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added this test because we haven't had any other tests like it so far. Here, we have both a shared library ( |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import netCDF4 as nc | ||
| import numpy as np | ||
|
|
||
| dataset = nc.Dataset("memory.nc", "w", diskless=True, persist=False) | ||
| dataset.createDimension("x", 3) | ||
| var = dataset.createVariable("data", np.float32, ("x",)) | ||
| var[:] = np.array([1.0, 2.0, 3.0]) | ||
| print(f"Data: {var[:]}") | ||
| dataset.close() |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| [tool.pyodide_pack] | ||
| requires = [ | ||
| "numpy", | ||
| "netcdf4", | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| [tool.pyodide_pack] | ||
| requires = [ | ||
| "numpy", | ||
| "scikit-learn" | ||
| ] |
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like to ask if it would be okay if I could address missing coverage in a further PR? The change doesn't do much; it just fails more gracefully by printing a warning when loading a dynlib. What I understand here that this loader is an elementary check and that we don't load the libs in the order they are supposed to be loaded in – we just run over what comes first in the list. It could be the case that I might have made a mistake somewhere. With this, the but at the same time, the code in |
Uh oh!
There was an error while loading. Please reload this page.