-
Notifications
You must be signed in to change notification settings - Fork 51
Bump pygame-ce to 2.5.6.dev2 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Okay, looks like it works fine with the demo examples: https://ryanking13.github.io/pyodide-pygame-demo/ |
Package Build ResultsTotal packages built: 28 Package Build Times (click to expand)
Longest build: pygame-ce (4m 10s) |
packages/pygame-ce/meta.yaml
Outdated
| post: | | ||
| # Remove docs to reduce the size of a wheel | ||
| # (Perhaps also remove typeshed and examples too?) | ||
| rm -rf ./pygame/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary, the docs are already removed by default in the emscripten build on our side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good to know. Thanks!
Co-authored-by: Ankith <[email protected]>
Removed post-build step to delete documentation.
Co-authored-by: Ankith <[email protected]>
Applies pygame-community/pygame-ce#3588
Maybe I should update pygame-ce cibuildwheel setting to include the WASM wheel to their releases. Let me do that as a follow-up. For now, let's build it ourselves.
Opening as a draft, as I haven't verified it with real examples yet.