Skip to content

[RTM after push] muscle length#375

Merged
pariterre merged 2 commits intopyomeca:masterfrom
EveCharbie:master
Oct 14, 2025
Merged

[RTM after push] muscle length#375
pariterre merged 2 commits intopyomeca:masterfrom
EveCharbie:master

Conversation

@EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Oct 7, 2025

This change is Reviewable

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pariterre reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)


binding/python3/wrapper/muscle.py line 502 at r1 (raw file):

        return [muscle.length_jacobian for muscle in self.data]

    def length(

Thanks to this PR I just notice length_jacobian should have been lengths_jacobian (and therefore these new ones should be plural too). I was about to commit push myself, but I wanted to make sure you could see the message, so I leave it to you to push with plural name

@pariterre pariterre changed the title [READY FOR FEEDBACK] muscle length [RTM after push] muscle length Oct 7, 2025
@EveCharbie
Copy link
Collaborator Author

@pariterre Thanks, I just pushed the "s".
Are there tests for the biorbd.Biorbd() Python API ?

@pariterre
Copy link
Member

@EveCharbie
The tests are for pretty much all the code, that is C++ core, and C, Python and Matlab binders, and the Python wrapper. But due to the fact that I am pretty much alone, there are a lot of blind spots in the tests...
Thanks for the changes :)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pariterre reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit 8325eaa into pyomeca:master Oct 14, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants