Conversation
If "False" is sent as update_kinematics, then is does not cost much. That said, getting all at the same time is definitely more elegant
Yep |
Ipuch
left a comment
There was a problem hiding this comment.
@Ipuch reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @EveCharbie)
pyorerun/__init__.py line 23 at r1 (raw file):
) except ImportError: # BioBuddy is not installed, these classes will not be available
if you want to make a hard dependancy it's okay.
Code quote:
from .model_interfaces import (
BiobuddyModel,
BiobuddyModelNoMesh,
)
except ImportError:
# BioBuddy is not installed, these classes will not be availableexamples/biobuddy/models/Wu_Shoulder_Model_kinova_scaled_adjusted_2.bioMod line 1 at r1 (raw file):
version 4
modified this after the paths and the biorbd interface.
pyorerun/model_interfaces/__init__.py line 15 at r1 (raw file):
from .biobuddy_model_interface import BiobuddyModelNoMesh, BiobuddyModel except ImportError: # BioBuddy is not installed, these classes will not be available
same comment
Code quote:
try:
from .osim_model_interface import OsimModelNoMesh, OsimModel
except ImportError:
# OpenSim is not installed, these classes will not be available
pass
# Biobuddy
try:
from .biobuddy_model_interface import BiobuddyModelNoMesh, BiobuddyModel
except ImportError:
# BioBuddy is not installed, these classes will not be available|
@EveCharbie I don't remember what was the pb here, do you remember? |
|
@Ipuch The problem was the model duplicate. I just fixed it. Let me know if it's OK for you :) |
|
One final requirement for me to merge safely. I need to know to which version of biobuddy we need to stick.
|
|
Made the requested changes, will have to wait tonight to publish the new version on pip |
|
@Ipuch published BioBuddy v0.2.0 to pip :) |
Answering to Issue #62
I have some questions:
rangesorrangesqor both recognized by biorbd ?This change is