feat: detect architecture/libc from wheel #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 92.24% 92.68% +0.44%
==========================================
Files 22 21 -1
Lines 1573 1737 +164
Branches 286 326 +40
==========================================
+ Hits 1451 1610 +159
- Misses 74 77 +3
- Partials 48 50 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
mayeut
force-pushed
the
drop-arch
branch
2 times, most recently
from
003423f to
1d319cf
Compare
kou
pushed a commit
to apache/arrow
that referenced
this pull request
Jun 5, 2025
… to match newest auditwheel naming (#46705) ### Rationale for this change The new version of auditwheel has added improvements to detect libc / platform on the wheels: - pypa/auditwheel#548 This has updated the ordering of the platform tags for some of the generated wheels. For the case of our manylinux_2014 and libc 2.17 but only for Python 3.13 amd64 and 3.13t arm64. The rest are using the old order. ### What changes are included in this PR? Force the newest version and update to new order of platform tags. ### Are these changes tested? Via archery. ### Are there any user-facing changes? No * GitHub Issue: #46691 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
alinaliBQ
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
…l name to match newest auditwheel naming (apache#46705) ### Rationale for this change The new version of auditwheel has added improvements to detect libc / platform on the wheels: - pypa/auditwheel#548 This has updated the ordering of the platform tags for some of the generated wheels. For the case of our manylinux_2014 and libc 2.17 but only for Python 3.13 amd64 and 3.13t arm64. The rest are using the old order. ### What changes are included in this PR? Force the newest version and update to new order of platform tags. ### Are these changes tested? Via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#46691 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #512
Getting the musllinux version for cross-repaired musl wheels is not handled yet here.
fixes #390: the default platform is changed from highest policy to
autowhich represents the highest compatible platform tag for any given wheel.