mypy: Fix all func-returns-value #362
Open
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
mypy--Fix-all-func-returns-value
branch
from
641daab to
99d3a10
Compare
Avasam
commented
Oct 17, 2025
Comment on lines
+60
to
+64
| if not dry_run: | ||
| try: | ||
| name.mkdir(mode=mode, parents=True, exist_ok=True) | ||
| except OSError as exc: | ||
| raise DistutilsFileError(f"could not create '{name}': {exc.args[-1]}") |
Contributor
Author
There was a problem hiding this comment.
https://github.com/pypa/distutils/pull/343/files#r2440539508
This one could be ignored on the line itself without being unsafe.
It's an unused expression, both mypy and pyright warn here because of the lack of assignement, it "looks like" a possible mistake because the result of the expression is not used for anything. But it's just a conditional execution pattern.
It's definitely more of a lint than a type error.
Avasam
force-pushed
the
mypy--Fix-all-func-returns-value
branch
from
99d3a10 to
d70e53a
Compare
Avasam
force-pushed
the
mypy--Fix-all-func-returns-value
branch
from
d70e53a to
fafa5d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would "fix itself" with #335