Fix regex tests on Python 3.14 #383
Open
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Nov 2, 2025
| if os.sep == '\\': | ||
| sep = re.escape(os.sep) | ||
| sep = re.escape(os.sep) if os.sep == '\\' else os.sep | ||
| # https://docs.python.org/3/whatsnew/3.14.html#re |
Avasam
commented
Nov 2, 2025
| sep = os.sep | ||
| if os.sep == '\\': | ||
| sep = re.escape(os.sep) | ||
| sep = re.escape(os.sep) if os.sep == '\\' else os.sep |
Contributor
Author
There was a problem hiding this comment.
Alternatively:
Suggested change
| sep = re.escape(os.sep) if os.sep == '\\' else os.sep | |
| sep = r"\\" if os.sep == "\\" else os.sep |
or even:
Suggested change
| sep = re.escape(os.sep) if os.sep == '\\' else os.sep | |
| sep = re.escape(os.sep) |
Avasam
force-pushed
the
Fix-regex-tests-on-Python-3.14
branch
from
f8db9de to
9ac82dc
Compare
Avasam
commented
Nov 2, 2025
| # function) -- authors of new compiler interface classes are | ||
| # responsible for updating 'compiler_class'! | ||
| compiler_type: ClassVar[str] = None # type: ignore[assignment] | ||
| compiler_type: ClassVar[str] = None |
Contributor
Author
There was a problem hiding this comment.
Will be added back in #368 , but tests currently fails with this due to unused type-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381
This updates tests expectations, but alternatively I can update
glob_to_re's implementation to always capitalize\zso that the result stays consistent across Python versions (at least for as long as\Zstays supported, which I guess is gonna be quite a while)