Skip to content

Fix CI error#2045

Closed
DimitriPapadopoulos wants to merge 1 commit intopypa:masterfrom
DimitriPapadopoulos:mypy
Closed

Fix CI error#2045
DimitriPapadopoulos wants to merge 1 commit intopypa:masterfrom
DimitriPapadopoulos:mypy

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

src/hatch/env/collectors/plugin/hooks.py:15: error: Unused "type: ignore" comment  [unused-ignore]
        return [CustomEnvironmentCollector, DefaultEnvironmentCollector]  ...
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
backend/src/hatchling/builders/hooks/plugin/hooks.py:15: error: Unused "type: ignore" comment  [unused-ignore]
        return [CustomBuildHook, VersionBuildHook]  # type: ignore[list-it...
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/hatch/env/collectors/plugin/hooks.py:15: error: Unused "type: ignore"
comment  [unused-ignore]
        return [CustomEnvironmentCollector, DefaultEnvironmentCollector]  ...
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
backend/src/hatchling/builders/hooks/plugin/hooks.py:15: error: Unused
"type: ignore" comment  [unused-ignore]
        return [CustomBuildHook, VersionBuildHook]  # type: ignore[list-it...
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft September 13, 2025 09:35
@cjames23
Copy link
Copy Markdown
Member

This is fixed in another PR that has this fix along with some fixes for unit tests and some chores like removing 3.8 support. #2061

@ofek
Copy link
Copy Markdown
Contributor

ofek commented Sep 27, 2025

Sorry for the lack of review time, I appreciate you helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants