Skip to content

Fix potential relpath bug on Windows platform #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix potential relpath bug on Windows platform #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/installer/destinations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from installer.records import Hash, RecordEntry
from installer.scripts import Script
from installer.utils import (
_WINDOWS,
Scheme,
construct_record_file,
copyfileobj_with_hashing,
Expand Down Expand Up @@ -267,10 +268,13 @@ def finalize_installation(
def prefix_for_scheme(file_scheme: str) -> Optional[str]:
if file_scheme == scheme:
return None
path = os.path.relpath(
self.scheme_dict[file_scheme],
start=self.scheme_dict[scheme],
)
if _WINDOWS: # pragma: no cover
path = os.path.abspath(self.scheme_dict[file_scheme]) # noqa: PTH100
else:
path = os.path.relpath(
self.scheme_dict[file_scheme],
start=self.scheme_dict[scheme],
)
return path + "/"

record_list = list(records)
Expand Down
Loading