-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update ci workflows #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update ci workflows #1775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is initially interesting, but I have a better example.
Mimic these if you want to continue working on this PR: https://github.com/ansible/receptor/blob/794e4c402c7045091e111a3bfc97722a2af214ba/.github/workflows/reusable-nox.yml#L58-L64 / https://github.com/ansible/receptor/blob/794e4c402c7045091e111a3bfc97722a2af214ba/.github/workflows/pull_request.yml#L87-L120. Without the go or project-specific stuff, of course. Follow the naming conventions too.
The "module" should be named reusable-*
. The conditionals should live outside that reusable module. The call to nox should be split into provisioning and execution.
Besides that, I'd rather have version bumps in a separate PR.
874318f
to
c863690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the CI workflows by updating GitHub Actions versions and introducing a reusable workflow pattern to reduce duplication. The changes update actions/checkout from v3 to v4, actions/setup-python from v4 to v5, and add pip caching configuration.
Key changes:
- Update GitHub Actions to newer versions with enhanced caching
- Refactor test workflow to use a reusable build workflow
- Add pip caching to improve build performance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/translation.yml | Updates action versions and adds pip caching configuration |
.github/workflows/test.yml | Refactors to use reusable workflow and splits build/linkcheck jobs |
.github/workflows/build.yml | New reusable workflow for common build steps |
run: | | ||
python -m pip install --upgrade nox virtualenv | ||
|
||
- name: Nox ${{ matrix.noxenv }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step references ${{ matrix.noxenv }}
but this workflow uses inputs, not a matrix strategy. This should be ${{ inputs.nox-env }}
to match the input parameter defined in the workflow.
- name: Nox ${{ matrix.noxenv }} | |
- name: Nox ${{ inputs.nox-env }} |
Copilot uses AI. Check for mistakes.
📚 Documentation preview 📚: https://python-packaging-user-guide--1775.org.readthedocs.build/en/1775/