Clearly specify that the name and version should be normalized for .dist-info and .data directories in wheels
#1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dist-info` and `.data` directories in wheels It's implied by https://packaging.python.org/en/latest/specifications/recording-installed-packages/#the-dist-info-directory as the resulting directory upon unpacking is supposed to be normalized.
for more information, see https://pre-commit.ci
Member
Author
|
I opened https://discuss.python.org/t/exlpicitly-requiring-dist-info-and-data-in-wheel-files-use-normalized-name-and-version/77275 to get clearance for this to be merged. |
pfmoore
reviewed
Jan 15, 2025
Co-authored-by: Paul Moore <[email protected]>
Contributor
|
Please add a line to the History section, too. |
Member
|
As per my comment on the Discourse thread: I do plan to approve & merge this, I'm just waiting until early next week to give folks a chance to object if they consider this a spec change, rather than just a clarification. |
webknjaz
reviewed
Jan 17, 2025
webknjaz
reviewed
Jan 17, 2025
webknjaz
approved these changes
Jan 17, 2025
ncoghlan
approved these changes
Jan 21, 2025
Member
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
No objections have been raised here or on the Discourse thread, so approving and merging :)
Thanks for the additional reviews, folks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's implied by https://packaging.python.org/en/latest/specifications/recording-installed-packages/#the-dist-info-directory as the resulting directory upon unpacking is supposed to be normalized.
📚 Documentation preview 📚: