-
Notifications
You must be signed in to change notification settings - Fork 1.4k
A discussion on helping downstream packaging #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
96058cc
Start a discussion on helping downstream packaging
mgorny b4cb7d2
Add a section on Internet access
mgorny df7081c
Also suggest the option of splitting test data into separate archive
mgorny cff76df
Add a section on system dependencies
mgorny be242a8
Add a section on downstream testing
mgorny 9f9af53
Expand on downstream testing, and add emphasis for readability
mgorny 00f39e5
Reorganize into why/how sections, and add emphasis
mgorny 08c70e8
Elaborate a bit more on why it's good to help downstreams
mgorny 24f552e
Correct "pytest" capitalization
mgorny 24b0346
Apply suggestions from code review
mgorny 16288af
Apply more suggestions from code review
mgorny b4c7485
Attempt addressing the remaining review comments
mgorny df0c91a
Add a section on stable channels
mgorny fc72a38
Retitle as "Supporting downstream packaging"
mgorny 24462f4
Add a "not all-or-nothing" sentence
mgorny 29cc38a
Add a note that downstreams can send patches to fix these issues
mgorny 9d5fbe6
Capitalize Git, per @pawamoy
mgorny 4d95da2
Fix inconsistent case in bullet points and remove duplicate
mgorny 6f55709
Apply typo fixes, thanks to @pawamoy
mgorny 548ab34
Clarify that source distribution needs only package's files
mgorny e925da1
Fix inconsistent whitespace between sentences
mgorny 0eb407c
Make the point of reusing source distribution lighter
mgorny 94743f9
Clarify the Internet part
mgorny 704d1a5
Apply suggestions from code review
mgorny e596609
Remove duplicate paragraph
mgorny 169281d
Clarify source distributions
mgorny bb8ac35
Add non-reproducibility argument for changing resources
mgorny addf891
Mention removing duplication of patches and inconsistency
mgorny 8a3a56c
Reword installing tests to make it clearer
mgorny 58eaf85
Give an example of "catastrophic failure"
mgorny 76aaf79
Indicate that some distributions require building from sources
mgorny 4f97860
Merge branch 'main' into discussion-downstream
ncoghlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.