Skip to content

Conversation

@freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Feb 5, 2025

Adds documentation for the iOS PEP 730, Android PEP 738 platform tags.
Also adds documentation for macOS tags, given they have their own quirks (especially regarding the universal fat architecture specification).

Fixes #1801
Fixes #1802


📚 Documentation preview 📚: https://python-packaging-user-guide--1804.org.readthedocs.build/en/1804/

@freakboy3742
Copy link
Contributor Author

FYI @mhsmith

Copy link

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS tag information LGTM, thanks.

@freakboy3742
Copy link
Contributor Author

The macOS tag information LGTM, thanks.

Thanks for the pointers on what the actual ground truth is here.

FYI: I've opened pypi/warehouse#17566 to track the issue on warehouse, and python/cpython#129712 to track the missing documentation (and inconsistency with --with-universal-archs specification).

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a ton @freakboy3742!

@di di requested a review from a team February 6, 2025 11:35
@mhsmith
Copy link
Member

mhsmith commented Feb 7, 2025

I don't have access to resolve my conversations above, but everything looks good to me now.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks @freakboy3742. If CI checks are happy, I will try to merge.

@willingc willingc added this pull request to the merge queue Feb 10, 2025
Merged via the queue into pypa:main with commit c07b39a Feb 10, 2025
7 checks passed
@freakboy3742 freakboy3742 deleted the mobile-tags branch February 10, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document PEP 730 in "Platform compatibility tags" specification Document PEP 738 in "Platform compatibility tags" specification

6 participants