-
Notifications
You must be signed in to change notification settings - Fork 1.4k
simple-repository-api: add PEP 792, clean up layout #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
NB: Linkcheck is failing elsewhere: |
ncoghlan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. One minor tweak to the inline history suggested.
https://math-atlas.sourceforge.net/ is resolving for me now, so it's plausible it was just a glitch and rerunning CI (which will happen automatically if the suggestion is accepted) may make the error go away.
Co-authored-by: Alyssa Coghlan <[email protected]>
|
Looks like the link is fixed, but a different anchor is now broken. I'll fix that... |
|
Nope, still broken: That page loads correctly for me in my browser, so it's presumably a UA or IP blocking thing. |
|
@woodruffw Offending links are ignored on main now, but I'm not seeing the "update branch" button in the web UI, so you appear to be the one that needs to push that. |
Ah yeah, that's because my PR is from an org fork rather than a user fork, and GitHub has never fixed that bug. Sorry for the confusion, just updated! |
This PR serves two purposes:
It integrates the recently-approved PEP 792 into the living PyPUG specifications, so that I can complete the procedural step of linking to PyPUG from the PEP itself
In the process of integrating this spec into the living simple repository API spec, I attempted to clean up, streamline, and fix the "flow" of the current spec. In particular:
All changes besides the ones approved with PEP 792 should be non-semantic, i.e. they should only make the spec easier to read, not change any pre-existing behaviors.
📚 Documentation preview 📚: https://python-packaging-user-guide--1879.org.readthedocs.build/en/1879/