test: Extend pip_install_local() test helper #13484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
added
C: tests
|
Aha, actually, |
ichard26
force-pushed
the
tests/helpers-2
branch
from
7cb2168 to
dffe746
Compare
ichard26
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to write tests that exclusively use local test data (and don't use the Internet). I've converted over a handful of tests to demonstrate what the new helper look like in practice, but I don't plan on mass converting all applicable tests since that would a lot of work for not much gain.
My next step would be to inspect all of the tests currently marked as requiring the network (after #13481 is merged) and rewrite as many as possible to use local test data exclusively instead.