Skip to content

Handle malformed version metadata error and skip the package #13513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Handle malformed version metadata error and skip the package #13513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3914e4
Fix handling of TypeError exception when invalid version metadata ent…
sepehr-rs Jul 29, 2025
a22bcbf
Show log message to inform user of malformed metadata
sepehr-rs Jul 29, 2025
238fac5
Add newsfile
sepehr-rs Jul 29, 2025
13f70d7
Fix pre-commit errors
sepehr-rs Jul 29, 2025
d2c4614
Merge branch 'main' into fix-version-metadata-error
sepehr-rs Aug 1, 2025
f081bf8
Update _envs.py
sepehr-rs Aug 1, 2025
0091c2f
Update _dists.py
sepehr-rs Aug 1, 2025
7e2ab99
Update 13443.bugfix.rst
sepehr-rs Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/13443.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Handle malformed ``Version`` metadata entries and
show a sensible error message instead of crashing.
10 changes: 8 additions & 2 deletions src/pip/_internal/metadata/importlib/_dists.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from pip._internal.utils.wheel import parse_wheel, read_wheel_metadata_file

from ._compat import (
BadMetadata,
BasePath,
get_dist_canonical_name,
parse_name_and_version_from_info_directory,
Expand Down Expand Up @@ -165,9 +166,14 @@ def canonical_name(self) -> NormalizedName:

@property
def version(self) -> Version:
if version := parse_name_and_version_from_info_directory(self._dist)[1]:
try:
version = (
parse_name_and_version_from_info_directory(self._dist)[1]
or self._dist.version
)
return parse_version(version)
return parse_version(self._dist.version)
except TypeError:
raise BadMetadata(self._dist, reason="invalid metadata entry `version`")

@property
def raw_version(self) -> str:
Expand Down
Loading