Skip to content

Fix fatal config set error #13535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

sepehr-rs
Copy link
Contributor

Fixes #13279

I tried fixing this by providing the user with a helpful error message instead of crashing, and made a new parser to allow writing to the PIP_CONFIG_FILE environment variable temporarily.

One important caveat is that changes made to the config file via PIP_CONFIG_FILE may not be reflected in other commands like pip config get due to how pip loads config scopes.

Would appreciate any feedback on this :).

@sepehr-rs sepehr-rs changed the title Fix config error Fix fatal config set error Aug 11, 2025
@sepehr-rs
Copy link
Contributor Author

I think pre-commit is showing weird behavior here again...
I've changed the problematic files but it is still failing with the old files.

@notatallshaw
Copy link
Member

notatallshaw commented Aug 12, 2025

I think pre-commit is showing weird behavior here again...
I've changed the problematic files but it is still failing with the old files.

Do you know if there is anything particular about your git workflow? It does seem to be happening with your PRs more than anyone else's (though I have seen it happen at least once to mine).

You could perhaps report this to pre-commit, I would normally assist in reporting a bug but my experience with that project means I am not inclined to help it out.

In the mean time I'm thinking we should move off pre-commit.ci, and instead just add it as a github workflow, I don't see any advantage to having it run in a separate infrastructure. I'll make an issue and a PR when I have a moment.

@sepehr-rs
Copy link
Contributor Author

I think pre-commit is showing weird behavior here again...
I've changed the problematic files but it is still failing with the old files.

Do you know if there is anything particular about your git workflow? It does seem to be happening with your PRs more than anyone else's (though I have seen it happen at least once to mine).

You could perhaps report this to pre-commit, I would normally assist in reporting a bug but my experience with that project means I am not inclined to help it out.

In the mean time I'm thinking we should move off pre-commit.ci, and instead just add it as a github workflow, I don't see any advantage to having it run in a separate infrastructure. I'll make an issue and a PR when I have a moment.

No, I don’t think the issue is on my end. It might be that committing too quickly causes these problems. And sure, I’ll report this as a potential bug to pre-commit. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip config set ERROR: Fatal Internal error [id=2]. Please report as a bug.
2 participants