-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix: Fix PowerShell completion test for Register-ArgumentCompleter #13577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
823f88e
to
453b8fd
Compare
Hi @notatallshaw, could you take a look at this PR? |
@meet-vasita thanks for raising this PR, unfortunately I have next to zero experience with both powershell and completions, so I am unlikely to be able to review this, hopefully another maintainer will pick this up when they have time, otherwise I will try and eventually add it on to my review list. This PR did make me think we should move this completion scripts out into their own files, so we can at least run some basic syntax checks, and IDEs will better be able support development work on them. But that should be in a separate PR to this one. |
Thanks @notatallshaw for the update! I understand, and I’ll wait for another maintainer to review. I agree that moving the completion scripts into separate files sounds like a good improvement for the future. |
Thanks @notatallshaw, I’ll add the venv to my global git ignore. |
I use powershell, but I've never used the completion scripts from pip. So I don't have any direct experience with this (and I'm not familiar with the powershell completion APIs). I'll try to find some time to take a look, but it could well be a few weeks before I have any spare time to do so. |
Thanks @pfmoore, no worries I appreciate you taking a look whenever you get the time. |
I created #13593 because this PR doesn't work for me as it registers completions for the wrong command, but that's a more general issue. I don't have time right now to try to work around the more general bug in order to test this PR. |
Updates pip’s PowerShell completion and its test to the modern Register-ArgumentCompleter style, replacing the old TabExpansion script.
Closes #12440.