Eliminate network access from some download, upgrade, and list tests#13714
Merged
Eliminate network access from some download, upgrade, and list tests#13714
Conversation
This way these tests don't have to access PyPI nor build the INITools sdist which are both slow.
ichard26
added
C: tests
ichard26
changed the title
ichard26
commented
Dec 21, 2025
Unfortunately, there are lots of other list tests that do depend on the network, but they look non trivial to fix.
ichard26
force-pushed
the
test/improve-slow-tests
branch
from
713399f to
2dd94f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #13707.
Unsurprisingly, some of our slowest tests (after #13713) are those that use the network. After this PR, we're down to
98functional tests with thenetworkmarker.