-
Notifications
You must be signed in to change notification settings - Fork 20
feat: PEP 794 support (METADATA 2.5) #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
ceed6cb to
4a57eff
Compare
Signed-off-by: Henry Schreiner <[email protected]>
c113f2b to
aaa53aa
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
3c00e43 to
7acc8ac
Compare
Signed-off-by: Henry Schreiner <[email protected]>
7acc8ac to
6a8898a
Compare
Signed-off-by: Henry Schreiner <[email protected]>
|
I've added these two checks:
I didn't add this one:
@brettcannon, thoughts, does that sound right? |
That's a typo on my part; pypa/packaging.python.org#1939 .
That's covered by, "Projects SHOULD list all the shortest import names that are exclusively provided by the project." So if you want to be strict then your proposal makes sense it just isn't technically illegal as long as there isn't some weird namespace interleaving (e.g. |
|
Ah, no, not for this check, I see. Okay, yes, I think you could have a normal package with a namespace package inside of it. I'll leave off such a check. |
|
Okay, so I don't think the extra check is needed. I'll merge this too then if abravalheri/validate-pyproject#271 passes @abravalheri's review. |
; private.(Inspired by pypa/packaging#948)