version.py including __all__
#1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
commented
Oct 1, 2024
RonnyPfannschmidt
requested changes
Oct 1, 2024
|
Nice, I just did it 👌 please let me know if I did it incorrectly |
RonnyPfannschmidt
approved these changes
Oct 3, 2024
|
Thanks for the approval. I don't have the ability to merge this fyi |
|
the change log fragment was not matching the tooling, but its my falt it wasn't documented well enough - thanks for making it nice and doing the extra round-trip, to ensure its awesome 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1075