Skip to content

Enforce more ruff rules #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Enforce more ruff rules #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a77b421
Enforce more ruff rules
DimitriPapadopoulos Feb 24, 2025
c4917e4
Apply ruff/flake8-logging-format rule G004
DimitriPapadopoulos Feb 24, 2025
448838e
Ooops... Fix mypy error in CI
DimitriPapadopoulos Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ version = { attr = "_own_version_helper.version"}
[tool.setuptools_scm]

[tool.ruff]
lint.select = ["E", "F", "B", "UP", "YTT", "C", "DTZ", "PYI", "PT", "I", "FURB", "RUF"]
lint.ignore = ["B028"]
lint.extend-select = ["YTT", "B", "C4", "DTZ", "ISC", "LOG", "G", "PIE", "PYI", "PT", "FLY", "I", "C90", "PERF", "W", "PGH", "PLE", "UP", "FURB", "RUF"]
lint.ignore = ["B028", "LOG015", "PERF203"]
lint.preview = true

[tool.ruff.lint.isort]
Expand Down
2 changes: 1 addition & 1 deletion src/setuptools_scm/_run_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def has_command(
try:
p = run([name, *args], cwd=".")
if p.returncode != 0:
log.error(f"Command '{name}' returned non-zero. This is stderr:")
log.error("Command '%s' returned non-zero. This is stderr:", name)
log.error(p.stderr)
except OSError as e:
log.warning("command %s missing: %s", name, e)
Expand Down
2 changes: 1 addition & 1 deletion src/setuptools_scm/_version_cls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from packaging.version import InvalidVersion
from packaging.version import Version as Version
except ImportError:
from setuptools.extern.packaging.version import ( # type: ignore[import-untyped, no-redef]
from setuptools.extern.packaging.version import ( # type: ignore[import-not-found, no-redef]
InvalidVersion,
)
from setuptools.extern.packaging.version import ( # type: ignore[no-redef]
Expand Down
Loading