Add warning for people adding dependencies #1133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To hopefully prevent regressions like pypa#1131 from happening again.
|
Ideally there would be a CI check of some kind that tried building from source to catch these issues, but this is hopefully a first step. |
|
In near future there will be new dependencies The bootstrap issue will get a solution |
|
OK, I'm curious as to what that will look like :) But in the meantime, are you saying you don't want this patch? At least to me it seems like a simple solution to temporarily avoid more regressions. |
|
im closing this one as its a particular detail of the build pipeline the solution will be a build backend for build-system deps that hopefully allows sdists that can self-install with only that dependency and that particular dependencies sdist being able to self-contained self-building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To hopefully prevent regressions like #1131 from happening again.