Skip to content

dont infer version in cli if --no-version is given #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

dont infer version in cli if --no-version is given #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
- fix #501: add py.typed
- fix #804: git - use fallback version instead of 0.0 when no version is found at all
- fix #1139: use logging.lastResort instead of a own replica to avoid polluting logging._handlerList
- fix #873: don't infer version in cli if --no-version is given

## v8.3.1

Expand Down
11 changes: 7 additions & 4 deletions src/setuptools_scm/_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,13 @@ def main(args: list[str] | None = None) -> int:
file=sys.stderr,
)
config = Configuration(root=inferred_root)

version = _get_version(
config, force_write_version_files=opts.force_write_version_files
)
version: str | None
if opts.no_version:
version = "0.0.0+no-version-was-requested.fake-version"
else:
version = _get_version(
config, force_write_version_files=opts.force_write_version_files
)
if version is None:
raise SystemExit("ERROR: no version found for", opts)
if opts.strip_dev:
Expand Down
Loading