chore: allow unraisable exceptions again, seems we no longer trigger the error #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PYTHONTRACEMALLOC=1 on Windows runners to debug gc errors with popen objects in test_case_cwd_evil[git]
RonnyPfannschmidt
force-pushed
the
unraisable
branch
from
6cbdcea to
6fb72b7
Compare
- Add proper proc.wait() call in finally block to ensure process is reaped - Add timeout and fallback to proc.kill() to prevent hanging - This should resolve gc errors with popen objects in test_case_cwd_evil[git] on Windows The previous code only called proc.wait() in the exception handler, leaving processes unreleased in the normal flow, which could cause gc warnings about unclosed subprocess popen objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #510