Skip to content

Fix 986 better override env var name #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

Fix 986 better override env var name #1176

merged 2 commits into from
Aug 4, 2025

Conversation

RonnyPfannschmidt
Copy link
Contributor

closes #986

  • better var names inthe docs for the override dist names
  • more lenient env var matching + close match finding for better debugging of user errors

@RonnyPfannschmidt
chore: use DIST_ANME in docs
9aa1d75 
- easier to read than NORMALIZED_DIST_NAME
- addresses part of pypa#986
@RonnyPfannschmidt
hardend environment override finding
becaeb4 
- match non-normalized suffixes
- show close matches on miss for typos
@RonnyPfannschmidt RonnyPfannschmidt merged commit 8ed737b into pypa:main Aug 4, 2025
21 checks passed
RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this pull request Aug 4, 2025
@RonnyPfannschmidt
Merge pull request pypa#1176 from RonnyPfannschmidt/fix-968-better-ov…
f8bb4bc 
…erride-env-var-name

Fix 986 better override env var name
@RonnyPfannschmidt RonnyPfannschmidt deleted the fix-968-better-override-env-var-name branch August 4, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

change env var variable name to something more comprehensble than NORMALIZED_DIST_NAME

1 participant

@RonnyPfannschmidt