reiterate version inference #1202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic version verification - Introduced should_infer method in PyProjectData to determine if version inference should proceed based on configuration. - Updated version_inference.py to utilize should_infer for handling version inference conditions. - Modified tests to reflect changes in dynamic version verification and ensure proper error handling when dynamic=['version'] is missing.
- enable dependency injecting supposed pyporject data - migrate tests to ue the api directly instead of writing
…bility - Updated the path representation in the pytest report header to replace 'site-packages' with 'site:.' and the current working directory with 'CWD:.' for improved clarity.
…missing sections - Introduced a class method `empty` in PyProjectData for creating empty instances. - Simplified the `read_pyproject` function to utilize the new `empty` method when the configuration file is missing. - Enhanced logging for missing tool sections in the TOML configuration.
- Introduced `InvalidTomlError` to handle parsing errors in TOML files. - Simplified the `read_pyproject` function by removing unnecessary exception handling for file not found. - Updated exception handling in version inference to use `InvalidTomlError` for better clarity in error logging.
- Introduced `_given_result` parameter in `read_pyproject` - expand the setuptools integration points with it - Improved error handling by allowing direct injection of `PyProjectData`, `InvalidTomlError`, or `FileNotFoundError` for better testability.
- drop magic boolean parameters - drop unused exception creator - simplify calls
the decission tree is massively simplified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aftermath of #1150
turns out legacy projects have many variables to enable inference easy
now we depend on the section again
im also moving towards better unit-testing of the conditions as i eventually want to bring it back as a extra
closes #1198
closes #1201