Merged
Conversation
Contributor
|
You should ignore |
Avasam
reviewed
May 22, 2024
DimitriPapadopoulos
force-pushed
the
UP
branch
6 times, most recently
from
4b1668e to
2b3c085
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
2 times, most recently
from
78ff278 to
6347575
Compare
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
UP
branch
2 times, most recently
from
172fe8d to
5360321
Compare
Avasam
reviewed
Jun 29, 2024
Contributor
Avasam
left a comment
Avasam
left a comment
There was a problem hiding this comment.
Some comments and imo potential non-automated improvements I noticed from also having applied UP03 in other projects
DimitriPapadopoulos
force-pushed
the
UP
branch
6 times, most recently
from
8c26c35 to
02086f8
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
2 times, most recently
from
ba3eccc to
eb25d9a
Compare
Avasam
reviewed
Aug 17, 2024
DimitriPapadopoulos
force-pushed
the
UP
branch
4 times, most recently
from
1499a0a to
c6bc8e7
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
from
c6bc8e7 to
661f48e
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
from
661f48e to
335bb01
Compare
Contributor
Author
|
Restarted from scratch, it's easier and less error-prone than rebasing. |
DimitriPapadopoulos
force-pushed
the
UP
branch
2 times, most recently
from
3a21e6c to
8e32c41
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
from
5ee902c to
a896611
Compare
Contributor
|
Might wanna disable UP027 too (I've done so here: #4558) |
DimitriPapadopoulos
force-pushed
the
UP
branch
from
a896611 to
5b88473
Compare
DimitriPapadopoulos
force-pushed
the
UP
branch
from
5b88473 to
146c3d1
Compare
Contributor
|
CI failure looks completely unrelated, I got the same thing here: https://github.com/pypa/setuptools/actions/runs/11113018762/job/30876386043?pr=4556 |
DimitriPapadopoulos
force-pushed
the
UP
branch
from
146c3d1 to
2e10c29
Compare
UP030 Use implicit references for positional format fields
UP031 Use format specifiers instead of percent format
UP032 Use f-string instead of `format` call
DimitriPapadopoulos
force-pushed
the
UP
branch
from
2e10c29 to
f65ea5b
Compare
Contributor
|
@jaraco and/or @abravalheri Can this be reviewed? Finishing to enable all |
Member
|
Looks great. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Enforce ruff/pyupgrade rules (
UP).Follow-up of #4125.
Pull Request Checklist
newsfragments/.(See documentation for details)