Skip to content

Drop test dependency on path package#4818

Closed
Avasam wants to merge 1 commit intopypa:mainfrom
Avasam:Drop-test-dependency-on-path-package
Closed

Drop test dependency on path package#4818
Avasam wants to merge 1 commit intopypa:mainfrom
Avasam:Drop-test-dependency-on-path-package

Conversation

@Avasam
Copy link
Contributor

@Avasam Avasam commented Feb 1, 2025

Summary of changes

As far as I can tell, pathlib+jaraco.path should be sufficient, and it's only used in tests. There may be issues with vendored deps, let's see what the CI says.

Closes

Pull Request Checklist

  • Changes have tests (these are the test changes)
  • News fragment added in newsfragments/. (no public changes, tests only)
    (See documentation for details)

@Avasam Avasam changed the title Drop test dependency on path package Drop test dependency on path package Feb 1, 2025
@Avasam Avasam force-pushed the Drop-test-dependency-on-path-package branch from 03814ed to 3dc6443 Compare February 1, 2025 20:29
@Avasam Avasam force-pushed the Drop-test-dependency-on-path-package branch from 3dc6443 to 9e5fc4b Compare February 1, 2025 20:35
@Avasam
Copy link
Contributor Author

Avasam commented Feb 1, 2025

After making this PR for something that looked like an unnecessary extra dependency. I went and looked at what exactly is path (my first assumption being that it was some compat module from before pathlib). Especially https://pypi.org/project/path#advantages .
It makes me curious about the separation between jaraco/path and jaraco/jaraco.path.

I also noticed that path.Path.parts and pathlib.Path.parts are incompatible (one's a method, the other's a property)

@Avasam Avasam closed this Feb 1, 2025
@Avasam Avasam deleted the Drop-test-dependency-on-path-package branch June 20, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant