Require email confirmation for TOTP-based logins #18689
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
reviewed
Sep 17, 2025
| def send_unrecognized_login_email(request, user, *, ip_address, user_agent, token): | ||
| return { | ||
| "username": user.username, | ||
| "ip_address": ip_address, |
There was a problem hiding this comment.
suggestion: include geo data as well
There was a problem hiding this comment.
When running a manual verification, the email sent was only text, not HTML. Any clue as to why?
There was a problem hiding this comment.
Are you talking about the ConsoleAndSMTPEmailSender in local dev? I don't think it displays HTML, only text:
warehouse/warehouse/email/services.py
Line 157 in f891447
There was a problem hiding this comment.
I am - one line above it is the note that you can visualize the HTML version in MailDev, which usually displays something richer for other emails.
di
commented
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18425.
This PR maintains a record of device information across logins for each user: