Skip to content

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Sep 24, 2025

Closes #18732 and #18796

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Sep 27, 2025

WIP:

Screenshot From 2025-09-27 07-44-27

TODO:

  • Update select to show values in "pretty" format - e.g. CP26 becomes CPython 2.6
  • Update table to show values in "pretty" format - e.g. CP26 becomes CPython 2.6
  • Show "No files match your selection" message when user filters by a combination which returns no results
  • Limit the filters based on what the user has already selected
  • Provide quick option to reset the filters (?)
  • Update URL based on filters

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Sep 27, 2025

Question how should we format the ABI?

Example options for the ABI cp36m:

image

OR

image

OR

image

OR

image

@merwok
Copy link
Contributor

merwok commented Sep 27, 2025

IMO it should not be just m (pymalloc), but needs to include all the parts: m and other modifiers don’t make sense without the first part cp36.

Unless it’s guaranteed that an abi tag cp36m always has an interpreter tag of cp36, but I am not sure about that.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Sep 27, 2025

Ok, thanks for your feedback @merwok, and for your comments on the associated issue.
I've added "Update URL based on filters" to the TODO list

re: ABIs, I've added a couple more options above - based on your feedback, I think the third option is best: CPython 3.6m (pymalloc)

@di
Copy link
Member

di commented Oct 3, 2025

@nlhkabu We might want to address #18796 here as well.

@miketheman
Copy link
Member

@nlhkabu We might want to address #18796 here as well.

Looks like there's a clause for this being added - https://github.com/pypi/warehouse/pull/18741/files#diff-057bf4a747c150d9f3f76db209a6c8f689b023a8e7cd41d96fcc549492889da7R563 - maybe instead of 3, 1 is a better value?

@merwok
Copy link
Contributor

merwok commented Oct 3, 2025

I suggested 3 as threshold: it’s not useful to filter a list of 1 item, or 2 items.
(One could argue for a minimum of 5 or 6 as well!)

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Oct 3, 2025

Yep, currently only showing the filters when there are more than 3 wheels, but happy to adjust that value based on feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Hide disproportionally large wheel filtering widget in pure-python projects Update layout file details page to improve overall design/usability
4 participants