Debian patches - distutils, hypothesis, rle object comparison #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Distutils is deprecated. Use setup from setuptools. * Do not cythonize while cleaning.
The Rle.__ne__ method returns an Rle object (for element-wise comparison), not a boolean. This caused RleDict.__eq__ to always return False for non-empty RleDicts because any non-empty Rle is truthy. Fix by comparing runs and values arrays directly.
This patch fixes the deprecated parameters of settings() function from the latest hypothesis version and overrides deadline parameter values
Collaborator
|
I will have a look :) |
Contributor
Author
|
There's more suggestions coming, so better wait until we've finished work on the package. |
Collaborator
|
Thanks! I'm super busy with a new baby but if the changes are very small they will be easy to review. Or I can get an llm to do it xD |
Contributor
Author
Congrats!! And enjoy! I've now added the last patch from jcfp. I think that's it from our side. |
Collaborator
|
I will have a look tomorrow :) |
Collaborator
|
Thanks. I'm amazed people use this library since there is so few stars and I never get github comments about it. |
Contributor
Author
Well, this is just Debian users with popcon installed, who wish to share statistics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, during debian packaging we are applying the patches in this PR.
Please consider merging them. Feedback welcome ;-)
Br,
Pieter