Skip to content

Avoid trivial subs #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ordabayevy wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Avoid trivial subs #545

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
404c98c
avoid trivial subs
Jul 30, 2021
cbd4e4f
Merge branch 'master' of https://github.com/pyro-ppl/funsor into triv…
Aug 4, 2021
f2e8c24
simple failing test
Aug 4, 2021
3587221
more tests
Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion funsor/terms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,8 +873,12 @@ class SubsMeta(FunsorMeta):

def __call__(cls, arg, subs):
subs = tuple(
(k, to_funsor(v, arg.inputs[k])) for k, v in subs if k in arg.inputs
(k, to_funsor(v, arg.inputs[k]))
for k, v in subs
if k in arg.inputs and k is not v
Copy link
Member

@eb8680 eb8680 Aug 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if v is already a Variable?

)
if not subs:
return arg
return super().__call__(arg, subs)


Expand Down