distributions.mixtures._MixtureBase: mixtures lack reparameterized sa…#2106
Merged
fehiepsi merged 1 commit intopyro-ppl:masterfrom Dec 14, 2025
Merged
Conversation
…mpling Testing Done: create a mixture distribution, check its has_rsample Signed-off-by: Eli Sennesh <elisennesh@gmail.com>
Collaborator
|
Thanks for the PR! $ root@557f2b12b9a8:/# python -c "import numpyro; print(numpyro.distributions.mixtures._MixtureBase().has_rsample)"
TrueIs your concern that it returns |
Member
|
I think we don't have rsample for those distributions. The default check in Distribution does not apply because we don't have reparam parameters defined here. |
fehiepsi
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mpling
Testing Done: create a mixture distribution, check its has_rsample