Skip to content

ci: pre-commit hook to auto-format yaml files#2112

Merged
juanitorduz merged 3 commits intopyro-ppl:masterfrom
Qazalbash:yaml-formatter
Dec 22, 2025
Merged

ci: pre-commit hook to auto-format yaml files#2112
juanitorduz merged 3 commits intopyro-ppl:masterfrom
Qazalbash:yaml-formatter

Conversation

@Qazalbash
Copy link
Collaborator

@Qazalbash Qazalbash commented Dec 20, 2025

Pre-commit hook to auto-format yaml files using google/yamlfmt.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, do we need to install this to develop numpyro? If so could you add dependency to dev?

@Qazalbash
Copy link
Collaborator Author

Just curious, do we need to install this to develop numpyro? If so could you add dependency to dev?

It's just a part of the pre-commit hook; you don't need to install it separately.

@Qazalbash
Copy link
Collaborator Author

@fehiepsi, just a thought, why are there no pre-commit hooks in CI?

@juanitorduz
Copy link
Collaborator

juanitorduz commented Dec 20, 2025

+1 in pre-commit hooks in ci :)

(I could draft a PR)

@juanitorduz
Copy link
Collaborator

CI error solved in #2113

@juanitorduz
Copy link
Collaborator

CI error solved in #2113

@Qazalbash, this fix has been merged so you should be able to rebase so than we can merge :)

@Qazalbash
Copy link
Collaborator Author

@juanitorduz done

@juanitorduz juanitorduz merged commit ceac631 into pyro-ppl:master Dec 22, 2025
9 checks passed
@juanitorduz
Copy link
Collaborator

Thanks @Qazalbash :D

@Qazalbash Qazalbash deleted the yaml-formatter branch December 22, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants