Add Types to numpyro.distributions.distribution
#2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
reviewed
Jan 20, 2026
numpyro/distributions/continuous.py
Outdated
| from jax.scipy.stats import norm as jax_norm | ||
| from jax.typing import ArrayLike | ||
|
|
||
| from numpyro._typing import DistributionT |
Member
There was a problem hiding this comment.
can we just depend on Distribution, instead of DistributionT? We have some success in constraints.py and transforms.py, which do not use ConstraintT and TransformT. We want to reduce the scope of using DistributionT through the library. Ideally, it's great to not use those protocols at all to avoid confusion.
Member
There was a problem hiding this comment.
Maybe grep DistributionT and remove at other scripts too? :)
Collaborator
Author
There was a problem hiding this comment.
Sure! Started on c27121b and fixing edge cases in the following commits :)
fehiepsi
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2036