Skip to content

Conversation

martinfleis
Copy link
Member

When doing Graph == not a graph, the check currently raises an AttributeError as show in pysal/esda#395. This fixes it and fixes pysal/esda#395.

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.2%. Comparing base (e47859e) to head (ab8e529).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #809     +/-   ##
=======================================
- Coverage   85.4%   84.2%   -1.2%     
=======================================
  Files        150     150             
  Lines      15954   15956      +2     
=======================================
- Hits       13620   13430    -190     
- Misses      2334    2526    +192     
Files with missing lines Coverage Δ
libpysal/graph/_set_ops.py 94.5% <100.0%> (ø)
libpysal/graph/tests/test_set_ops.py 100.0% <100.0%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinfleis
Copy link
Member Author

CI failure unrelated.

@ljwolf
Copy link
Member

ljwolf commented Oct 10, 2025

Yes, the failing tests should probably be skipped, rather than failing due to missing pyproj.

@jGaboardi
Copy link
Member

Yes, the failing tests should probably be skipped, rather than failing due to missing pyproj.

@ljwolf --> @sjsrey added this in 6471872 of #791

@martinfleis martinfleis merged commit acf870c into pysal:main Oct 10, 2025
11 of 12 checks passed
@martinfleis martinfleis deleted the set_opsd branch October 10, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError in Local_Join_Counts

3 participants