Skip to content

Conversation

u3ks
Copy link
Collaborator

@u3ks u3ks commented Oct 5, 2025

The notebook has:

  • same place as the clustering tutorial and same variables
  • Overture data
  • Neatnet
  • ETC + adaptive limit + postprocessing
  • No spatial lag
  • S3
  • Dealing with noise

Anything missing ? maybe itd be good to cache the overture data, because it takes 4-5 minutes just reading it ...

Copy link

codecov bot commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.2%. Comparing base (4037c70) to head (913a7df).
⚠️ Report is 121 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #712     +/-   ##
=======================================
+ Coverage   97.4%   98.2%   +0.9%     
=======================================
  Files         26      26             
  Lines       4328    4215    -113     
=======================================
- Hits        4214    4141     -73     
+ Misses       114      74     -40     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinfleis
Copy link
Member

Can we do OSM data and osmnx as we do elsewhere in the guide? Any reason to use Overture?

@u3ks
Copy link
Collaborator Author

u3ks commented Oct 5, 2025

the only reason was to be consistent with urban_taxonomy, but changing to osmnx shouldnt make a difference really. We'll have to drop/change the tunnel and street type filtering though

@martinfleis
Copy link
Member

That is fine, we don't need to be 1:1 with the paper here. The other is not either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants