Skip to content

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Feb 26, 2023

This PR:

@jGaboardi jGaboardi self-assigned this Feb 26, 2023
@jGaboardi
Copy link
Member Author

@martinfleis Any chance for a review on this? 99.99% infrastructure/formatting changes and no changes in code functionality.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note in code.

The CI failure is expected?

Can you make sure that pre-commit.ci is green?

@jGaboardi
Copy link
Member Author

The CI failure is expected?

The CI failure is recorded in #346 and only started with pysal/libpysal#511. I haven't been able to track down the reason.

@jGaboardi
Copy link
Member Author

Can you make sure that pre-commit.ci is green?

Oh man. Not sure how this fell through the cracks. The PR had been passing ruff+black locally for me, not sure how all these got reverted. I'll look into it.

@jGaboardi
Copy link
Member Author

pre-commit.ci is now back to green.

@jGaboardi
Copy link
Member Author

ugh... many more failures after ruffing.

@jGaboardi
Copy link
Member Author

@martinfleis All tests back to green (except the 'expected' 3.11-DEV' failure) after my ruffing debacle. Thanks for your patience.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks!

@jGaboardi jGaboardi merged commit 151f5cb into pysal:main Mar 2, 2023
@jGaboardi jGaboardi deleted the format_lint_repo branch March 2, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate report for CI failure adopt pyproject.toml

2 participants