Fixed Pyodide transform w/ LiteralMap #111
Merged
+22
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually ... I am going to just publish this as the current state is pretty broken due this regression. |
3 tasks
|
Amazing, thanks for tracking this down so quickly! |
|
@philippjfr the real "hero" here has been @MarcSkovMadsen giving me tons of details to play around and reproduce ... your "so quickly" was "eternal hellish time" to me though 🤣 but I am super happy I've found the culprit. I can't even blame Pyodide because we asked for that LiteralMap magic to happen, I just forgot that indeed it's yet another Proxy to deal with and now that's hopefully done right. |
|
Great work. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes holoviz/panel#7015 by understanding not just PyProxy but also the recently introduced LiteralMap that might be passed along 3rd party modules or code that does explicit conversion.
As those proxies cannot survive postMessage dance or serialization in general, they are currently normalized when passed from the worker to the main thread so that errors related to that special
[object Map]is gone.I took the opportunity to also relax coincident warnings on deadlock when it's just main/worker channel being slow (a lot with current panel example).
This has been tested in PyScript already but it needs to land before so I can update the version.
/cc @ntoll @philippjfr @MarcSkovMadsen