Skip to content

miniterm: implement --reconnect, exit(1) on error #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
belm0 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

miniterm: implement --reconnect, exit(1) on error #651

belm0 wants to merge 2 commits into from

Conversation

@belm0
Copy link

@belm0 belm0 commented May 15, 2022 •
edited
Loading

  • --reconnect option will silently retry (on the initially connected port)
  • only show received/send backtrace if --develop
  • exit with code 1 when there is an error

Fixes #558

$ python -m serial.tools.miniterm /dev/foo --reconnect
--- Miniterm on /dev/cu.wchusbserial51850172701  115200,8,N,1 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
fps:  65.4,  render:  1.0 ms
fps:  64.9,  render:  1.0 ms
fps:  64.7,  render:  1.0 ms

--- disconnected ---
fps:  64.5,  render:  1.0 ms
fps:  64.5,  render:  1.0 ms
fps:  64.5,  render:  1.0 ms

--- exit ---

@belm0
miniterm: implement --reconnect, exit(1) on error
e6ef024 
  * --reconnect option will silently retry (on the initially
    connected port)

  * exit with code 1 when there is an error

Fixes pyserial#558
@belm0 belm0 mentioned this pull request May 15, 2022
Closed
TheMatt2
TheMatt2 reviewed Jul 1, 2023
View reviewed changes
serial/tools/miniterm.py
self.console.cancel()
raise # XXX handle instead of re-raise?
if not self.quiet:
sys.stderr.write('--- receive exception ---\n')
Copy link

@TheMatt2 TheMatt2 Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be "--- received exception ---\n"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TheMatt2 TheMatt2 TheMatt2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

miniterm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reconnect after connection loss

3 participants

@belm0 @TheMatt2 @dpgeorge