Skip download in CDN mode#22
Merged
ArtyomVancyan merged 5 commits intopysnippet:masterfrom Mar 25, 2025
Merged
Conversation
This is a follow-up to pysnippet#20 pysnippet#21 added a CDN feature, which means the added script tag will point to the CDN version of mermaid.js. But it still tries to download a copy to the package's static directory in AppConfig.ready. Because this isn't necessary in CDN mode and causes us a PermissionError during deployment, I'm proposing we only download in non-CDN mode.
I think it's a better fit there, because the other tests all concern the template tag itself. Please note that the test fails for me locally.
Contributor
Author
|
Thank you for considering, @ArtyomVancyan ! When this is merged, the package will be used improving documentation at a company with nearly a thousand engineers. I think if it's ready for that, it's time to give it a |
Member
|
@maiksprenger, thanks for the PR. I totally agree that it shouldn't try to download the assets when it is in CDN mode. Liked the changes in the |
Contributor
Author
|
Amazing, thank you for merge and release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This is a follow-up to #20
#21 added a CDN feature, which means the added script tag will point to the CDN version of mermaid.js. Thank you again for adding that!
But
django-mermaidstill tries to download a copy to the package's static directory in AppConfig.ready. Because this isn't necessary in CDN mode and causes us aPermissionErrorduring deployment, I'm proposing we only download in non-CDN mode.All Submissions:
Changes to Core Features: