Skip to content

Conversation

@Quicksilver151
Copy link
Contributor

@Quicksilver151 Quicksilver151 commented Dec 9, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

was bored

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@port19x
Copy link
Collaborator

port19x commented Dec 10, 2024

I like it. Did you check all the files?

@Quicksilver151
Copy link
Contributor Author

Quicksilver151 commented Dec 10, 2024

i only modified two files

and it shouldnt effect any code. so not sure what you mean by check

btw not sure where to put this, but the link to allanime in the README.md needs to change

long story but thats sort of how i found the spell errors

@port19x
Copy link
Collaborator

port19x commented Dec 10, 2024

By check I meant spell check.
You can adapt the allanime link, we can do it in one PR.
Also adapt the allanime link in disclaimer.md while you're at it

@Quicksilver151
Copy link
Contributor Author

yea i went through all the files. changed everyhing the lsp suggested

@Quicksilver151
Copy link
Contributor Author

changed allanime references

@port19x port19x merged commit 2595908 into pystardust:master Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants