fix: Fix mvp player on WSL 2 #1478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derisis13
requested changes
Jan 25, 2025
| *Darwin*) player_function="${ANI_CLI_PLAYER:-$(where_iina)}" ;; # mac OS | ||
| *ndroid*) player_function="${ANI_CLI_PLAYER:-android_mpv}" ;; # Android OS (termux) | ||
| *MINGW* | *WSL2*) player_function="${ANI_CLI_PLAYER:-mpv.exe}" ;; # Windows OS | ||
| *MINGW* | *WSL2*) player_function="${ANI_CLI_PLAYER:-mpv}" ;; # Windows OS |
Collaborator
There was a problem hiding this comment.
This will make WSL use the mpv installed in WSL (which is what you wanted probably), but it'll break git bash because it also matches with *MINGW*, and it won't find mpv (but does find mpv.exe)
A better solution would be to remove the *WSL2* option and let it default to mpv, or even better for you to export the env var ANI_CLI_PLAYER as mpv
Contributor
|
Truly the most valuable player |
Collaborator
|
As @Derisis13 explained your change doesn't make full sense, I suggest you set the environment variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of change
Description
ramble here
Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-eselect episode works-Sselect index works-rrange selection works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases