Skip to content

Conversation

@topazrn
Copy link

@topazrn topazrn commented Jan 29, 2025

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

I'd like to have chapter information even without the --skip argument. This way, depending on my mood, I can manually skip or re-watch the op or ed by moving between chapters.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@topazrn topazrn requested a review from Derisis13 as a code owner January 29, 2025 03:18
@Derisis13
Copy link
Collaborator

Why would we do this? Can you not use the --skip argument?

@Derisis13
Copy link
Collaborator

Derisis13 commented Jan 29, 2025

Also the fact we have --no-detach not working might be worth looking into

@topazrn
Copy link
Author

topazrn commented Jan 29, 2025

I think the --skip argument should only be used for when we want to skip the op and ed. Having a chapter information is nice whether we want to skip the op and ed or not.

Turns out the --no-detach has always worked. I just misinterpreted what it was supposed to do.

@port19x
Copy link
Collaborator

port19x commented Feb 26, 2025

How does this behave when ani-skip is not installed?

@port19x
Copy link
Collaborator

port19x commented Apr 23, 2025

I think the --skip argument should only be used for when we want to skip the op and ed. Having a chapter information is nice whether we want to skip the op and ed or not.

Turns out the --no-detach has always worked. I just misinterpreted what it was supposed to do.

I disagree with this premise. Closing

@port19x port19x closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants