feat: fetch chapter information regardless of --skip argument#1479
Closed
topazrn wants to merge 3 commits intopystardust:masterfrom
Closed
feat: fetch chapter information regardless of --skip argument#1479topazrn wants to merge 3 commits intopystardust:masterfrom
topazrn wants to merge 3 commits intopystardust:masterfrom
Conversation
Collaborator
|
Why would we do this? Can you not use the --skip argument? |
Collaborator
|
Also the fact we have --no-detach not working might be worth looking into |
Author
|
I think the --skip argument should only be used for when we want to skip the op and ed. Having a chapter information is nice whether we want to skip the op and ed or not. Turns out the --no-detach has always worked. I just misinterpreted what it was supposed to do. |
Collaborator
|
How does this behave when ani-skip is not installed? |
Collaborator
I disagree with this premise. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
I'd like to have chapter information even without the --skip argument. This way, depending on my mood, I can manually skip or re-watch the op or ed by moving between chapters.
Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-eselect episode works-Sselect index works-rrange selection works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases