Skip to content

Conversation

@vishalk17
Copy link

@vishalk17 vishalk17 commented Feb 11, 2025

Type of Change

  • Feature

Description

Key Changes:

  • Audio Selection Prompt:
    After selecting an anime, the script checks if subbed and/or dubbed episodes are available.

  • User Choice:
    If both versions are available, you’ll be prompted to choose between them.

  • Automatic Sub Selection:
    If only the sub (subtitled) version is available and no dub (dubbed) version exists:

    • The script will automatically set the mode to "sub" without prompting the user to select the audio type.
    • This ensures seamless playback without unnecessary prompts when only one audio type is available.
  • Backward Compatibility:
    Retains the --dub flag to force the playback of dubbed episodes without prompting.

    • If the --dub flag is provided, the script will attempt to play dubbed episodes directly.
    • If dubbed episodes are not available, an appropriate error message will be displayed.

@vishalk17 vishalk17 requested a review from Derisis13 as a code owner February 11, 2025 12:11
@Derisis13
Copy link
Collaborator

I'd guess 80-90% of our users use subs exclusively. Having a prompt for every anime with dubs available would be straight up obnoxious to these people.

What about falling back to subs if --dub is specified but a dub is not available?

@vishalk17
Copy link
Author

vishalk17 commented Feb 11, 2025

I'd guess 80-90% of our users use subs exclusively. Having a prompt for every anime with dubs available would be straight up obnoxious to these people.

What about falling back to subs if --dub is specified but a dub is not available?

@Derisis13


I believe most people prefer dubbed versions if available. If not, they likely prefer subs.

There might be two cases:

  • Watching Old Anime (Both Sub/Dub Available):
    If the dubbed version is already there, why would I care to watch it with subs?

  • Watching New Anime (Only Sub Available):
    In this case, the choice would naturally be subs because, as an anime fan, I wouldn’t want to wait for the dubbed version to be released to watch a masterpiece.


Regarding the second question:

The --dub flag clearly indicates that the user wants to watch the dubbed version. If I build the logic as you suggested (falling back to subs when a dub isn’t available), it defeats the purpose of providing that flag.

However, in such cases, we could prompt the user:
"Dubbed version not available. Subbed version is available. Would you like to proceed with subs? (Y/N)"

This maintains the meaning of the --dub flag while still offering flexibility when dubs are unavailable.


Agree?

- Add logic to check availability of sub and dub versions of episodes
- Introduce prompts to select audio type if both sub and dub are available
- Automatically set mode to sub if only subbed version is available
- Retain --dub flag to force dubbed episodes without prompting
- Ensure backward compatibility with existing flags and options
@vishalk17 vishalk17 changed the title ani-cli : added seperate dubbed option ani-cli : Improve sub/dub availability checks and user prompts Feb 11, 2025
@vishalk17 vishalk17 changed the title ani-cli : Improve sub/dub availability checks and user prompts ani-cli : Improve sub/dub availability checks and user prompts Feb 11, 2025
@mrfluffy-dev
Copy link

mrfluffy-dev commented Feb 12, 2025

Ohh hell nah

Extra clicks not to be bothered by an inferior product (dub)

@justchokingaround
Copy link
Collaborator

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants