ani-cli : Improve sub/dub availability checks and user prompts #1484
ani-cli : Improve sub/dub availability checks and user prompts #1484vishalk17 wants to merge 1 commit intopystardust:masterfrom
Conversation
|
I'd guess 80-90% of our users use subs exclusively. Having a prompt for every anime with dubs available would be straight up obnoxious to these people. What about falling back to subs if |
I believe most people prefer dubbed versions if available. If not, they likely prefer subs. There might be two cases:
Regarding the second question:The However, in such cases, we could prompt the user: This maintains the meaning of the Agree? |
- Add logic to check availability of sub and dub versions of episodes - Introduce prompts to select audio type if both sub and dub are available - Automatically set mode to sub if only subbed version is available - Retain --dub flag to force dubbed episodes without prompting - Ensure backward compatibility with existing flags and options
|
Ohh hell nah Extra clicks not to be bothered by an inferior product (dub) |
|
no |
Type of Change
Description
Key Changes:
Audio Selection Prompt:
After selecting an anime, the script checks if subbed and/or dubbed episodes are available.
User Choice:
If both versions are available, you’ll be prompted to choose between them.
Automatic Sub Selection:
If only the sub (subtitled) version is available and no dub (dubbed) version exists:
Backward Compatibility:
Retains the
--dubflag to force the playback of dubbed episodes without prompting.--dubflag is provided, the script will attempt to play dubbed episodes directly.